Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember.String.fmt is deprecated in Ember 2+ #124

Open
Kilowhisky opened this issue Sep 16, 2015 · 1 comment
Open

Ember.String.fmt is deprecated in Ember 2+ #124

Kilowhisky opened this issue Sep 16, 2015 · 1 comment

Comments

@Kilowhisky
Copy link

Looks like they have decided to drop it.

emberjs/ember.js#10848

Its used here (

return Ember.String.htmlSafe(Ember.String.fmt(text, term));
)

    /*
      Format the no matches message, substituting the %@ placeholder with the
      html-escaped user input
     */
    options.formatNoMatches = function(term) {
      var text = self.get('typeaheadNoMatchesText');
      if (text instanceof Ember.Handlebars.SafeString) {
        text = text.string;
      }

      term = Ember.Handlebars.Utils.escapeExpression(term);

      return Ember.String.htmlSafe(Ember.String.fmt(text, term));
    };

And here (

return Ember.String.htmlSafe(Ember.String.fmt(text, errorThrown));
)

 /*
      Format the error message, substituting the %@ placeholder with the promise
      rejection reason
     */
    options.formatAjaxError = function(jqXHR, textStatus, errorThrown) {
      var text = self.get('typeaheadErrorText');

      return Ember.String.htmlSafe(Ember.String.fmt(text, errorThrown));
    };
@dzbo
Copy link

dzbo commented Oct 22, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants