Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-internal rule does not catch all internal API usages #84

Open
saskliutas opened this issue Oct 28, 2024 · 0 comments
Open

no-internal rule does not catch all internal API usages #84

saskliutas opened this issue Oct 28, 2024 · 0 comments

Comments

@saskliutas
Copy link
Member

There are some cases where no-internal rule does not produce an error:

// extending internal class does not result in lint error
class NewClass extends InternalClass {}
// taking internal class constructor as an argument does not result in lint error
function doSomething(construct: new () => InternalClass) {
  // impl
}

// passing internal class constructor as an argument does not result in lint error
doSomething(InternalClass);

These are examples that I have encountered. There might be more cases where referencing internal APIs or types does not result in an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant