Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a pipeline that confirms we successfully build against lowest possible peer deps #869

Open
grigasp opened this issue Feb 5, 2025 · 0 comments

Comments

@grigasp
Copy link
Member

grigasp commented Feb 5, 2025

Our packages, especially the legacy ones, have a number of peer dependencies specified with a wide range, e.g. ^4.4.0 || ^5.0.0. Generally, we're keeping our dev dependencies at the upper bound (e.g. 5.5) and have no real way of knowing that the packages actually build against the lower bound (e.g. 4.0).

At the very least we should make sure our packages build. Running the tests would be great, but I'm worried it would complicate the tests too much, as the results would likely be different based on the dependency versions that we use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant