Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree widget: Status of consuming Kiwi UI #1149

Open
11 tasks
MartynasStrazdas opened this issue Jan 24, 2025 · 1 comment
Open
11 tasks

Tree widget: Status of consuming Kiwi UI #1149

MartynasStrazdas opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
tree widget Tree widget or its components related issues

Comments

@MartynasStrazdas
Copy link
Contributor

MartynasStrazdas commented Jan 24, 2025

Current widget status

A short demo of the Kiwi-based tree widget at the current stage: https://github.com/user-attachments/assets/5a157d8c-c9a2-4410-9c74-eb331e7ae8d8

Current kiwi tree implementation: iTwin/presentation#847

iTwinUI v5 dependencies status

Below is a list of iTwinUI v5 components that have been successfully consumed or are still missing (based on status). The list is incomplete, more components / issues might appear in the future.

Components required for Tree rendering

Preview Give feedback

Components required for Tree widget

Preview Give feedback
@grigasp grigasp changed the title Tree-widget missing kiwi components/functionalities Tree widget: Status of consuming Kiwi UI Jan 24, 2025
@grigasp grigasp added the tree widget Tree widget or its components related issues label Jan 24, 2025
@GerardasB
Copy link
Contributor

Tree item equivalent error node component.

Would you like to display an error state for specific tree items? Or are you looking for an error state for the whole tree i.e. instead of displaying any nodes, it could say that the tree is empty or that there was a problem fetching data.

Multiline label

Can we simply expose a sub-label prop or would you like to update the styling of existing label i.e. to specify https://developer.mozilla.org/en-US/docs/Web/CSS/text-wrap?

Tree item expander click selects tree item (unconfirmed, might be our issue)

Are you using onExpandedChange? Seems to work fine in our sandbox w/o additional custom logic.

Unified onClick and onKeyDown for item selection (nice to have)

We have onSelectedChange for that use-case. But we are not handling multi selection (or key modifiers).

Dropdown menu button

You can use a DropdownMenu component.

Search box

Take a look at TextBox and IconButton components. I.e. you could create a simple search box by simply using decorations API:

<TextBox.Root>
	<TextBox.Icon href={searchIcon} />
	<TextBox.Input placeholder="Search" />
</TextBox.Root>
<IconButton
	icon={searchIcon}
	label="Search"
	variant="ghost"
/>

Progress radial (indeterminate)

This is available as a Spinner component.

Checkbox to have a partial state

We support "mixed" state in the Checkbox component. But I believe, there's a rendering issue, we'll investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree widget Tree widget or its components related issues
Projects
None yet
Development

No branches or pull requests

3 participants