Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new basemaps #16

Open
xavirayo opened this issue Jun 26, 2019 · 5 comments
Open

add new basemaps #16

xavirayo opened this issue Jun 26, 2019 · 5 comments

Comments

@xavirayo
Copy link

Is it possible to add new wms basemaps?
I tried it adding this to basemaps in app.js:
{"id": "GEBCO", "type": "tiled", "label": "GEBCO", "url": "https://www.gebco.net/data_and_products/gebco_web_services/web_map_service/mapserv?"}

And this to the set basemap function

} else if (basemap.type === 'tiled'){
if (basemap.id === 'GEBCO') {
options.attribution = "GEBCO";

But still can't visualize the layer although it appars in the basemaps list. Do you know what I'm doing wrong?

Thanks!

@slead
Copy link
Contributor

slead commented Jun 26, 2019

not sure, sorry. I'll take a look as soon as I can - this is a busy week in Australia as it's the end of financial year ;)

@xavirayo
Copy link
Author

xavirayo commented Jun 27, 2019 via email

@hardreddata
Copy link

I think bootleaf doesn't support WMS for basemap layers. That is, the GEBCO source is not the right format.

You can add these as layers, inside the layers section, in config.js

	{
		"id": "Test",
		"name": "Test",
		"type": "wmsTiledLayer",
		"url": "https://www.gebco.net/data_and_products/gebco_web_services/web_map_service/mapserv?",
		"layers": "GEBCO_LATEST"
	}

That displays for me. The next step would be to tidy up tocCategories higher up the file.

Stephen may have better ideas.

Cheers.

@xavirayo
Copy link
Author

xavirayo commented Jul 1, 2019 via email

@slead
Copy link
Contributor

slead commented Jul 1, 2019

I think @RussellGrew is right - the basemaps are hard-coded. It should be possible to modify that section so I'll take a look when time permits. Alternatively, feel free to make the changes and submit a PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants