add support for markdown text #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaozdl
force-pushed
the
feature/ignore_markdown
branch
from
46a7f26
to
f85ee77
Compare
iaguirre88
reviewed
Oct 17, 2020
There was a problem hiding this comment.
I really like your approach. However, instead of checking word by word, I think I would have replaced the whole string at once to get rid of every markdown word and then proceed as usual. What do you think?
Maybe shomething like this:
@markdown_words [
# ignore headers
"#+",
"(==)+",
. . .
]
{:ok, regex} = Regex.compile(Enum.join(@markdown_words, "|"))
new_text = Regex.replace(regex, text, "")
# then proceed as usual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Not every formatting option in markdown counts as a "word".
I took a very naive approach by filtering out only the options that look as a "word".