Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom confirmation dialogs #148

Open
iamlogand opened this issue Jul 9, 2023 · 0 comments
Open

Custom confirmation dialogs #148

iamlogand opened this issue Jul 9, 2023 · 0 comments
Labels
cosmetic UI changes that have little or no impact on functionality, but may enhance usability

Comments

@iamlogand
Copy link
Owner

Replace the confirm() function that is currently used to get the browser's default confirmation dialog (for game deletion) with a React component. This component could use MUI.

I would have proposed that the same component used for the sign out dialog should be used. However, that component was created "from scratch" before MUI was added to the app, so there is probably a much simpler way to make a dialog using MUI. Therefore, don't reuse the sign out dialog for this.

This component must be reusable. In the future, it would be great to implement it not only in the game lobby, but elsewhere in the app, including the play page.

@iamlogand iamlogand added the cosmetic UI changes that have little or no impact on functionality, but may enhance usability label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic UI changes that have little or no impact on functionality, but may enhance usability
Projects
None yet
Development

No branches or pull requests

1 participant