Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define distinct third party API user checks #98

Open
br648 opened this issue Nov 9, 2020 · 0 comments
Open

Define distinct third party API user checks #98

br648 opened this issue Nov 9, 2020 · 0 comments
Labels
question Further information is requested

Comments

@br648
Copy link
Contributor

br648 commented Nov 9, 2020

All checks for requestingUser.apiUser != null will need to be re-evaluated and potentially replaced with RequestingUser.isThirdPartyUser.

Observed behavior

requestingUser.apiUser != null check can apply to first or third party API users. In some cases this probably should be just third party users.

Expected behavior

To correctly define the task in hand and apply the appropriate first/third/both API user checks.

Steps to reproduce the problem

No steps as such, but and example can be found in OtpUserController.preCreateHook

Any special notes on configuration used

N/A

Version of otp-middleware and/or OpenTripPlanner if applicable (exact commit hash or branch name)

#84

@br648 br648 added bug Something isn't working question Further information is requested and removed bug Something isn't working labels Nov 9, 2020
@br648 br648 mentioned this issue Nov 9, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant