Trip Monitor analyzer improvement, status log #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
changed the title
br648
approved these changes
Dec 1, 2023
| // Performance note: Don't retrieve the full data for each trip at this time. | ||
| // This saves bandwidth and memory, as we don't use the trip data immediately besides the ID. | ||
| // The full data for each trip will be fetched at the time the actual analysis takes place. | ||
| // TODO: Filter out trips that would be skipped by the CheckMonitoredTrip. |
There was a problem hiding this comment.
Can this TODO be done now? If not, perhaps explain why. TODOs seem to have a habit of not getting done.
There was a problem hiding this comment.
Yes, thank you, I added one criterion in ca89702 and reworded the TODO.
| queueIterations++; | ||
| // Report queue status every minute (unless this job finishes before). | ||
| int runMillis = queueIterations * BLOCKING_QUEUE_DEPLETE_WAIT_TIME_MILLIS; | ||
| if ((runMillis % 60000) == 0) { |
There was a problem hiding this comment.
Could create a constant for 60000 and use here and further down.
There was a problem hiding this comment.
Refactored in ca89702.
| @@ -17,27 +17,27 @@ public class MonitoredTripLocks { | |||
| /** the amount of time in milliseconds to wait to check if a lock has been released */ | |||
| private static final int LOCK_CHECK_WAIT_MILLIS = 500; | |||
|
|
|||
| private static final ConcurrentHashMap<MonitoredTrip, Boolean> locks = new ConcurrentHashMap(); | |||
| private static final ConcurrentHashMap<String, Boolean> locks = new ConcurrentHashMap(); | |||
There was a problem hiding this comment.
SonarLint: Update to new ConcurrentHashMap<>()
There was a problem hiding this comment.
Refactored in ca89702.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR improves the performance of the trip monitoring job (and reduces the risk of bugs from dropped Mongo connections) and adds logging to inform when trip analysis queues and states remain non-empty/non-idle for too long.