Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trip sharing emails #273

Merged
merged 20 commits into from
Dec 9, 2024
Merged

Trip sharing emails #273

merged 20 commits into from
Dec 9, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR adds sending emails to confirmed users added to a monitored trip as primary traveler, companion, or observer.

@binh-dam-ibigroup binh-dam-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Nov 26, 2024
Base automatically changed from trip-sharing to dev December 3, 2024 21:40
@binh-dam-ibigroup binh-dam-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Dec 4, 2024
@binh-dam-ibigroup binh-dam-ibigroup marked this pull request as ready for review December 4, 2024 14:46
Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Just the one minor nit which didn't effect the unit tests anyway.

primary.userId = "primary-user-id";

MobilityProfileLite newPrimary = new MobilityProfileLite();
primary.userId = "new-primary-user-id";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newPrimary and not primary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! (02d74f9)

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Dec 5, 2024
@binh-dam-ibigroup binh-dam-ibigroup removed their assignment Dec 5, 2024
Copy link

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@binh-dam-ibigroup binh-dam-ibigroup merged commit 65e1d30 into dev Dec 9, 2024
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the trip-sharing-emails branch December 9, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants