-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trip sharing emails #273
Trip sharing emails #273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me. Just the one minor nit which didn't effect the unit tests anyway.
primary.userId = "primary-user-id"; | ||
|
||
MobilityProfileLite newPrimary = new MobilityProfileLite(); | ||
primary.userId = "new-primary-user-id"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newPrimary
and not primary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you! (02d74f9)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist
dev
before they can be merged tomaster
)Description
This PR adds sending emails to confirmed users added to a monitored trip as primary traveler, companion, or observer.