Propagate delete companion #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
br648
approved these changes
Dec 12, 2024
|
|
||
| // If a dependent user, remove self as the primary traveler in trips created by other users. | ||
| // TODO: Should we alert the user who created the trip of the deletion? | ||
| Persistence.monitoredTrips |
There was a problem hiding this comment.
There is probably a case here for just deleting the trip if the primary traveler is no longer travelling. Perhaps that would start to complicate things though?!
|
|
||
| /** | ||
| * Remove the specified user as observer from the specified trip. | ||
| * @return true if one or more related users gor invalidated, false otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR addresses #271 (comment).
When a user deletes their account, they are removed as primary traveler on trips saved by others,
and they are invalidated as companions and observers on trips saved by others.