Skip to content

Commit

Permalink
ci(google-auth): use workload identity federation instead of json
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Nov 12, 2024
1 parent 2650f7c commit 620bd00
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:

- uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GCP_CREDENTIALS }}
workload_identity_provider: "${{ secrets.WIF_PROVIDER_NAME }}"

- uses: google-github-actions/setup-gcloud@v2

Expand Down
14 changes: 8 additions & 6 deletions .github/workflows/ibis-backends-cloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ on:
types:
- labeled

permissions:
# this allows extractions/setup-just to list releases for `just` at a higher
# rate limit while restricting GITHUB_TOKEN permissions elsewhere
contents: read

env:
FORCE_COLOR: "1"
SQLALCHEMY_WARN_20: "1"
Expand Down Expand Up @@ -79,6 +74,13 @@ jobs:
key: snowpark
extras:
- --extra snowflake
# this allows extractions/setup-just to list releases for `just` at a higher
# rate limit while restricting GITHUB_TOKEN permissions elsewhere
permissions:
contents: "read"
# required for GCP workload identity federation
id-token: "write"

steps:
- name: checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -128,7 +130,7 @@ jobs:

- uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GCP_CREDENTIALS }}
workload_identity_provider: "${{ secrets.WIF_PROVIDER_NAME }}"

- name: setup databricks credentials
if: matrix.backend.name == 'databricks'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ibis-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:

- uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GCP_CREDENTIALS }}
workload_identity_provider: "${{ secrets.WIF_PROVIDER_NAME }}"

- uses: google-github-actions/setup-gcloud@v2

Expand Down

0 comments on commit 620bd00

Please sign in to comment.