Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Xalwaysclassgc to Test5102804 #849

Draft
wants to merge 1 commit into
base: openj9
Choose a base branch
from

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Nov 22, 2024

  • Updated the run directive with -Xalwaysclassgc jvm option
  • This is a temporary workaround and should be reviewed once the root cause is identified.

related: eclipse-openj9/openj9#20531

@annaibm annaibm marked this pull request as draft November 22, 2024 17:46
@llxia
Copy link
Contributor

llxia commented Nov 22, 2024

Please run in Grinder and add ibm license.

- Updated the @run with -Xalwaysclassgc jvm option
- This is a temporary workaround and should be reviewed once the root cause is identified.

related: eclipse-openj9/openj9#20531

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm
Copy link
Contributor Author

annaibm commented Nov 22, 2024

Grinder run:
TEST:java/beans/Introspector/Test5102804.java
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/45124/

 Timestamp: Fri Nov 22 18:21:48 2024 UTC 
# CUSTOM_TARGET: java/beans/Introspector/Test5102804.java
# TEST TARGETS RESULTS SUMMARY: TOTAL: 1   EXECUTED: 1   PASSED: 1   FAILED: 0   DISABLED: 0   SKIPPED: 0
# TESTCASES RESULTS SUMMARY: passed: 1; failed: 0; error: 0; skipped: 0 

@pshipton
Copy link
Member

I'm not sure this is a solution, just a temporary workaround, which we should call out in the commit description.
@dmitripivkine are you still investigating why this option is needed?

@pshipton
Copy link
Member

pshipton commented Nov 22, 2024

Also, this change should start at the openjdk head stream (openj9-openjdk-jdk) and then be backported to 23, 21, 17, and then 11. Unless for some reason it only fails on 11?

@dmitripivkine
Copy link

dmitripivkine commented Nov 22, 2024

I'm not sure this is a solution, just a temporary workaround, which we should call out in the commit description. @dmitripivkine are you still investigating why this option is needed?

Well, I have a plan to find out exact scenario. However I don't think there is something wrong with handling. This is combination class unloading - > clearing Weak Ref. OpenJ9 does not do class unloading every time. It does it for aggressive GC to prevent OOM but it is too late to process Weak Ref. If you need this test pass without pushing class unloading every single Global GC an alternative can be to have another run of aggressive Global GC. I am not sure it is necessary.

@pshipton
Copy link
Member

Continuing the discussion in eclipse-openj9/openj9#20531 (comment)

@annaibm
Copy link
Contributor Author

annaibm commented Nov 22, 2024

Also, this change should start at the openjdk head stream (openj9-openjdk-jdk) and then be backported to 23, 21, 17, and then 11. Unless for some reason it only fails on 11?

Based on the current results , The test: java/beans/Introspector/Test5102804.java -, seems to fail in both version 8 and 11, but not in versions 17, 21, or 23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants