Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 concerns #55

Open
philipengberg opened this issue Jun 20, 2017 · 7 comments
Open

2.0.0 concerns #55

philipengberg opened this issue Jun 20, 2017 · 7 comments

Comments

@philipengberg
Copy link

I just installed 2.0.0 and ran my app without doing any changes to my code.

EasyAnimation still swizzles without having called EasyAnimation.enable().

@philipengberg
Copy link
Author

I'm also wondering, with regard to the requests for a non-swizzling version, when I read about the need to call EasyAnimation.enable() I immediately cheered and thought "That must mean that there is also a EasyAnimation.disable(), so that I can exactly control when to use EasyAnimation and when not to", however, looking into the code that does not seem to be the case 😞

@philipengberg
Copy link
Author

The initial issue is invalid. Something must have gone during the CocoaPod installation. EasyAnimation is now not enabled by default.

However, I get this

screen shot 2017-06-20 at 07 01 47

@philipengberg philipengberg changed the title 2.0.0 does not need .enable() 2.0.0 concerns Jun 20, 2017
@icanzilb
Copy link
Owner

This is true, when installed via CP that method won't be public, I'll push a fix asap

@icanzilb
Copy link
Owner

@philipengberg Can you try with https://github.com/icanzilb/EasyAnimation/releases/tag/2.0.1 ? It's on CocoaPods

@vburojevic
Copy link

Seems that calling EasyAnimation.enable() after enabling it should re-swizzle the methods and disable it, but that's not the case. Any ideas @icanzilb? I'd like to make a PR to fix this if possible, and add disable function.

@vburojevic
Copy link

Ignore, my bad. UIViewController wasn't deallocated properly so code in viewWillDissapear didn't get called. :)

@vburojevic
Copy link

Nope, still had the issue because swizzle was a static block property and it could be called only once.

I opened a PR for this: #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants