Added the "MaxProtocol" method to set the maximum version for SMB connection. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adicionado método para definir o protocolo de SMB máximo.
Adicionado método para definir o protocolo de SMB máximo.
|
I found a request for this in the problems... |
|
I'm hesitant to add this until php-smbclient can support the same thing |
icewind1991
force-pushed
the
master
branch
2 times, most recently
from
e1438ac
to
6691355
Compare
icewind1991
force-pushed
the
master
branch
4 times, most recently
from
eda3870
to
29bdeba
Compare
icewind1991
force-pushed
the
master
branch
3 times, most recently
from
c1a84fc
to
0fc2a08
Compare
|
@icewind1991 now it can, see #99 (New eduardok smbclient option: smbclient_client_protocols) |
mmattel
reviewed
Jan 28, 2021
| /** | ||
| * @param integer $maxProtocol | ||
| */ | ||
| public function setMaxProtocol($maxProtocol) { |
There was a problem hiding this comment.
This function needs an adoption because you can set NT1 and SMB2/3.
The option should not be -m but --option... as you can see in the referenced issue above
icewind1991
force-pushed
the
master
branch
7 times, most recently
from
e4b0bcd
to
80a4edf
Compare
|
I've implemented this differently in 3.3.0, thanks for the work anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft has advised its clients that version 1 of SMB is disabled on servers, but with this method it is possible to set the version. Example: 2 or 3.