Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

375 radiation boost #382

Merged
merged 7 commits into from
Aug 15, 2024
Merged

375 radiation boost #382

merged 7 commits into from
Aug 15, 2024

Conversation

hknahal
Copy link
Contributor

@hknahal hknahal commented Nov 30, 2022

Related to #375

@hknahal
Copy link
Contributor Author

hknahal commented Nov 30, 2022

Tested in DEV and QA (version 122.*)

Test case that should pass validation:

Example 1: The reference_radiation_treatment_id field is submitted when a radiation boost was given (radiation_boost = Yes). This should pass validation.
Test files:
sample_registration.txt
donor.txt
primary_diagnosis.txt
treatment.txt
chemotherapy.txt
radiation.txt

radiationBoost_valid1

Test cases that should fail validation:
Example 1: The reference_radiation_treatment_id is submitted when no radiation boost was given (radiation_boost = No). This should fail validation.
Test files: (same as above except different radiation.txt file)
radiationfail1.txt

radiationBoost_fail1

Example 2: The reference_radiation_treatment_id is not submitted when radiation boost was given (radiation_boost = Yes). This should fail validation.
Test files (same as above except different radiation.txt file)
radiation_fail2.txt

radiationBoost_fail2

Pending test case: The submitter_treatment_id submitted in the reference_radiation_treatment_id field does not exist in previous Radiation submissions or the current Radiation submission. This will be tested when ticket icgc-argo/argo-clinical#856 is ready.

@Buwujiu
Copy link
Contributor

Buwujiu commented Dec 12, 2022

reference_radiation_treatment_id

Tested all cases in ALEXIS-INTL in QA, working as expected!

@hknahal
Copy link
Contributor Author

hknahal commented Dec 13, 2022

Pending clinical changes (icgc-argo/argo-clinical#856)

@puneet-oicr
Copy link

May be moved to 1.18 because testing is pending

@lindaxiang
Copy link
Contributor

The dictionary change for this feature and dependent clinical change (icgc-argo/argo-clinical#856) have both been tested in QA. This PR can be merged.

@lindaxiang lindaxiang merged commit d7940a0 into develop Aug 15, 2024
@lindaxiang lindaxiang deleted the 375_radiation_boost branch August 15, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants