Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] - Hop-chain #760

Open
pragyanshrestha-ibriz opened this issue Oct 2, 2023 · 3 comments
Open

[Project] - Hop-chain #760

pragyanshrestha-ibriz opened this issue Oct 2, 2023 · 3 comments
Assignees

Comments

@pragyanshrestha-ibriz
Copy link
Collaborator

Cosmos SDK chains integration with Centauri

@ibrizsabin
Copy link
Collaborator

The integration of wasm lightclient with relayer is a bit stuck right now due to incompatibility issue with the proto files declaration on javascore side. Once the proto files align with the cosmos official proto files we should be able to continue with the integration with relay.

@ibrizsabin
Copy link
Collaborator

ibrizsabin commented Jan 3, 2024

we have some deviations that we discovered during integration with hopchain. One is most of the values are hashed using shaSum instead of keccak. Another one being it tries to verify hash of acknowledgement bytes rather than the value itself . Which results in double hashing of value on light client resulting proof failure. For now i have patched it by trying to verify membership by once hashing the value and once not hashing the value but its not a good solution. To rectify this we would need to apply following changes
1.Make it convention to hash values using shasum rather than keccak in javascore BTPmessage , icon light client and relayer.
2. While creating btp message for acknowledgement hash the value twice so that it works seamlessly in light client.
We would need to verify that this works well with our deployed IBC as well.

@ibrizsabin
Copy link
Collaborator

After discussing this issue we have decided that the solution to resolve this properly would be to apply sha256 to acknowledgement and keccak it before generating btp message this will make our implementation closer to ibc spec. On light client side we have to make adjustments for older membership verification that provides raw acknowledgement bytes.

@pragyanshrestha-ibriz pragyanshrestha-ibriz changed the title Hop-chain [Project] - Hop-chain Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants