Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tagging suggestions #9

Open
lperovskaya opened this issue Jul 26, 2023 · 4 comments
Open

Allow tagging suggestions #9

lperovskaya opened this issue Jul 26, 2023 · 4 comments
Assignees

Comments

@lperovskaya
Copy link
Collaborator

Do you see Bill Poucher on a picture, but he's not properly tagged? We want you to tag that person!

Is there a way for us to make a "suggest change" button that will send suggested coordinates and person somewhere for a confirmation?

Or if it's complicated, can we build a local application / website version that will show a custom gallery version with ability to suggest changes and give a list of suggested changes as a file? We can then set up a tagging station onsite and ask people to tag their friends

@azat-ismagilov
Copy link
Member

I have one possible solution: create button with mailto and coordinates in title and body. This will work like this:

Submit changes

@lperovskaya
Copy link
Collaborator Author

This is actually brilliant! Can you calculate coordinates on click or something?
As in:
Click "edit"
Click on a face in the photo
Select person from a list or type a new person
Submit it into email

@azat-ismagilov
Copy link
Member

azat-ismagilov commented Jul 28, 2023

This is actually brilliant! Can you calculate coordinates on click or something? As in: Click "edit" Click on a face in the photo Select person from a list or type a new person Submit it into email

I will investigate this possibility and write to the ticket. Most likely it can be done with little effort.

azat-ismagilov added a commit that referenced this issue Aug 3, 2023
@lperovskaya
Copy link
Collaborator Author

Works great for now, minor possible improvements:
[] in email put each URL/string of tags on a separate line for easier copy-paste
[] editing mode of photo information panel is quite high -- it often covers the tagging overlay and i have to scale the page to type a name. Need to design that interface part in a more compact manner, or maybe move it out of the photo area altogether, TBD
[] if editing information panel has no university tagged the width of university tag is too small for comfort
[] it's easy to forget to press Enter after typing a name, have no idea how to fix it

@azat-ismagilov azat-ismagilov self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants