Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import scss file problem #428

Open
ssimk0 opened this issue Jun 2, 2023 · 0 comments
Open

Import scss file problem #428

ssimk0 opened this issue Jun 2, 2023 · 0 comments

Comments

@ssimk0
Copy link

ssimk0 commented Jun 2, 2023

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @id-sk/[email protected] for the project I'm working on.

we had problem with importing the scss files correrly

Here is the diff that solved my problem:

diff --git a/node_modules/@id-sk/frontend/idsk/components/header-extended/_header-extended.scss b/node_modules/@id-sk/frontend/idsk/components/header-extended/_header-extended.scss
index e61867e..8d13f26 100644
--- a/node_modules/@id-sk/frontend/idsk/components/header-extended/_header-extended.scss
+++ b/node_modules/@id-sk/frontend/idsk/components/header-extended/_header-extended.scss
@@ -1,5 +1,5 @@
 @import "../../base";
-@import "./node_modules/@fortawesome/fontawesome-free/scss/fontawesome.scss";
+@import "@fortawesome/fontawesome-free/scss/fontawesome.scss";
 
 @include govuk-exports("idsk/component/header-extended") {
   $idsk-header-background: govuk-colour("white") !default;

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant