Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dove modifications #387

Draft
wants to merge 5 commits into
base: devel
Choose a base branch
from
Draft

Conversation

dylanjm
Copy link
Collaborator

@dylanjm dylanjm commented Sep 30, 2024


Pull Request Description

What issue does this change request address?

#386

What are the significant changes in functionality due to this change request?

Ideally, no changes in functionality but everything will be different.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@dylanjm dylanjm marked this pull request as draft September 30, 2024 21:22
@dylanjm dylanjm force-pushed the dove-modifications branch 2 times, most recently from 531c675 to 84bc649 Compare October 2, 2024 20:57
@dylanjm dylanjm force-pushed the dove-modifications branch from 8e89003 to 860876c Compare October 15, 2024 23:12
@dylanjm dylanjm force-pushed the dove-modifications branch from 1552aaa to 731c206 Compare December 9, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants