Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited Syntax Highlighting - Only Brackets/Parentheses Highlighted #2

Open
XZF0 opened this issue Dec 15, 2024 · 1 comment
Open
Assignees

Comments

@XZF0
Copy link

XZF0 commented Dec 15, 2024

I installed the GBNF Highlighter extension and while it correctly associates with .gbnf files, the syntax highlighting appears to be limited. Only brackets, braces, and parentheses are being highlighted.

Expected Behavior

Based on the example screenshot in the repository, I expected highlighting for:

  • Keywords (::=)
  • String literals (in quotes)
  • Comments (starting with #)
  • Character classes and ranges
  • Special operators and quantifiers

Actual Behavior

Only [ { ( and their closing counterparts are highlighted. All other syntax elements remain unhighlighted.

Environment

  • VS Code Version: 1.93.1
  • GBNF Highlighter Version: released on 2024-02-16
  • OS: macOS
  • Color Theme: Tested with multiple themes in both light and dark modes

Troubleshooting Steps Taken

  1. Tried multiple VS Code color themes
  2. Verified no conflicting color customizations in settings
  3. Confirmed files are correctly associated with GBNF language mode
  4. Disabled background color override (my only color-related setting)

And a possible additional issue (matter of taste perhaps): There should not be ( [ { highlighting inside comments I think. There is currently. Is this intentional?

@iddar
Copy link
Owner

iddar commented Jan 28, 2025

Hello @XZF0

Thank you for taking the time to report this issue and for providing such detailed information! I sincerely apologize for the inconvenience caused by the limited syntax highlighting and the unexpected behavior within comments.

I appreciate your patience, and I want to let you know that I’m actively working on resolving these issues. The goal is to ensure that all syntax elements, as shown in the example screenshot, are correctly highlighted and that unnecessary highlighting (like brackets inside comments) is addressed.

I’ll provide an update here as soon as the fix is implemented. In the meantime, if you notice anything else or have additional feedback, please feel free to share it.

Thank you again for your understanding and for using the GBNF Highlighter extension!

Best regards

@iddar iddar self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants