Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form subclass mixup in upload_session_narrativeminutes #8483

Open
jennifer-richards opened this issue Jan 30, 2025 · 0 comments
Open

Form subclass mixup in upload_session_narrativeminutes #8483

jennifer-richards opened this issue Jan 30, 2025 · 0 comments
Labels
accepted bug Something isn't working component: meeting/ contrib-easy Easy dev difficulty for contribution minor

Comments

@jennifer-richards
Copy link
Member

I believe that the 'GET' branch of the upload_session_narrativeminutes() view is creating an instance of UploadMinutesForm where it should be using UploadNarrativeMinutesForm. This works for now because those forms have exactly the same Fields, so the 'POST' processing gets the input it expects, but would be an issue if those forms ever diverged.

datatracker/ietf/meeting/views.py

Line 2784 in 2946cdb

form = UploadMinutesForm(show_apply_to_all_checkbox)

@jennifer-richards jennifer-richards added accepted bug Something isn't working component: meeting/ contrib-easy Easy dev difficulty for contribution minor labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted bug Something isn't working component: meeting/ contrib-easy Easy dev difficulty for contribution minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jennifer-richards