Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show your own time votes in your "I've played this" list #1080

Closed
alice-blue opened this issue Nov 8, 2024 · 3 comments · Fixed by #1172
Closed

Show your own time votes in your "I've played this" list #1080

alice-blue opened this issue Nov 8, 2024 · 3 comments · Fixed by #1172
Labels
estimated play time Issues related to the Estimated Play Time feature

Comments

@alice-blue
Copy link
Contributor

On this page:

https://ifdb.org/playlist?type=played

The playlist page already shows the user's star ratings. Maybe it can show the time votes, too, so that users can easily see which games they've added times for.
@dfabulich dfabulich added the estimated play time Issues related to the Estimated Play Time feature label Nov 8, 2024
@alice-blue
Copy link
Contributor Author

Maybe this should be done as part of #582

@alice-blue alice-blue mentioned this issue Nov 18, 2024
Open
@dfabulich dfabulich mentioned this issue Nov 18, 2024
Closed
@alice-blue
Copy link
Contributor Author

alice-blue commented Nov 22, 2024 •
edited
Loading

Now that time votes are public, this could be shown to all users who are able to see the user's played list.

@alice-blue
Copy link
Contributor Author

alice-blue commented Nov 23, 2024 •
edited
Loading

Ok, I have a branch to show times on the "I've played it" list, but I'm not sure whether to create a PR for it right now. It's set up so that it will display time votes regardless of whether you're looking at your own play list or someone else's, but it will only display the public ones (the ones above record number 388). Even on your own played list. Is that confusing? Should I just wait until Dec. 19 for this?

Edit: Never mind. I made a version that does show anonymous votes if it's your own list you're looking at.

@alice-blue alice-blue mentioned this issue Nov 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
estimated play time Issues related to the Estimated Play Time feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show the user's play time on the "I've played it" list alice-blue/ifdb
2 participants
@dfabulich @alice-blue