Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game search results should have a similar template, whether there's a cover or not #1126

Open
salty-horse opened this issue Nov 13, 2024 · 3 comments · May be fixed by #1176
Open

Game search results should have a similar template, whether there's a cover or not #1126

salty-horse opened this issue Nov 13, 2024 · 3 comments · May be fixed by #1176
Labels
searches Improvements in IFDB's search functionality visual design Improve how IFDB looks

Comments

@salty-horse
Copy link
Collaborator

This search yields 3 games, one of them without a cover.

It's confusing that the game without the cover is presented differently, with the year and rating in different positions, and the comma after the game title.

search
@dfabulich dfabulich mentioned this issue Nov 14, 2024
Closed
@dfabulich dfabulich added searches Improvements in IFDB's search functionality visual design Improve how IFDB looks labels Nov 15, 2024
@salty-horse salty-horse mentioned this issue Nov 20, 2024
Open
@alice-blue
Copy link
Contributor

alice-blue commented Nov 21, 2024 •
edited
Loading

I wonder if it would help to float the cover art to the right, the way we do on the viewgame page? Then the text would line up on the left regardless of whether the game had cover art. (There would still be other things to fix to make them uniform.)

@salty-horse
Copy link
Collaborator Author

I prefer the cover art to be on the left, with a blank space when it doesn't exist.
Unlike game pages, I don't think search results should fill the width of their "column", which is what a float right for the cover would do. (Maybe it's just my personal taste.)

@salty-horse salty-horse linked a pull request Nov 23, 2024 that will close this issue
Open
@salty-horse
Copy link
Collaborator Author

The same issue exists in lists. Example
(Note the lack of spacing above the user's comment when there is no cover)
list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
searches Improvements in IFDB's search functionality visual design Improve how IFDB looks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify appearance of game search results with/without covers salty-horse/ifdb
3 participants
@salty-horse @dfabulich @alice-blue