-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: try to connect to parent xmpp domain #1876
base: main
Are you sure you want to change the base?
Conversation
0473d43
to
3373169
Compare
I'm thinking that this is behavior that's already in Openfire? |
i think i have found an edge case: For example: i have a srv record for mopsdom.de, but a wildcard * for subdomains to another server which has nothing to do with xmpp
i used gajim and connected with an account to mopbook(xmppdomain) to make some service discoverys on mopsdom.de (xmppdomain) and i ran into:
i could reproduce this with other service subdomains (pubsub,...) too then i inserted the fallback if the connection could not be established Otherwhise for every xmpp-subdomain a cname entry to dns have to be inserted to overcome this issue... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a useful optimisation, and is disabled by default. LGTM 👍
…bdomain (service) was found... add configuration property to enable/disable the fallback
3373169
to
4aa803c
Compare
rebased to current master... |
If no dns entry was found for xmpp service subdomain, try to connect to xmpp domain host itself.
Example:
If the dns entry for conference.xmppdomain, pubsub.xmppdomain, search.xmppdomain was not set the method will now try to connect to the (parent) xmppdomain, cause the service will mostly run on the same host as the subdomain service.