Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split sample_bipartite() into two functions for the G(n,m) and G(n,p) case #630

Open
szhorvat opened this issue Jan 9, 2023 · 4 comments · May be fixed by #1627
Open

Split sample_bipartite() into two functions for the G(n,m) and G(n,p) case #630

szhorvat opened this issue Jan 9, 2023 · 4 comments · May be fixed by #1627
Assignees
@maelle
Labels
lifecycle Deprecating old APIs

Comments

@szhorvat
Copy link
Member

szhorvat commented Jan 9, 2023 •
edited
Loading

What is the feature or improvement you would like to see?

Separate sample_bipartite() into sample_biparite_gnm() and sample_bipartite_gnp(), and eventually deprecate sample_bipartite().

Motivation

  • Consistency with the separate sample_gnm() and sample_gnp()
  • The $G(n,p)$ and $G(n,m)$ models are conceptually distinct
  • Reduces the number of optional argument
  • Explicit function names that reduce confusion
  • Already have separate igraph_bipartite_game_gnp() and igraph_bipartite_game_gnm() available in C/igraph

References
@krlmlr krlmlr added the lifecycle Deprecating old APIs label May 20, 2023
@szhorvat
Copy link
Member Author

Consider this for 2.0 @krlmlr @maelle?

@maelle
Copy link
Contributor

maelle commented Dec 19, 2023

Noting that if we do, the deprecation code for bipartite.random.game() will need to be updated.

@szhorvat szhorvat mentioned this issue Dec 20, 2023
Closed
@szhorvat szhorvat mentioned this issue May 2, 2024
Merged
13 tasks
@maelle maelle self-assigned this Sep 23, 2024
@maelle
Copy link
Contributor

maelle commented Dec 10, 2024

What to do regarding bipartite()?

@maelle maelle linked a pull request Dec 10, 2024 that will close this issue
Open
@szhorvat
Copy link
Member Author

What to do regarding bipartite()?

Same thing, split into bipartite_gnm and bipartite_gnp. Perhaps sample_(bipartite()) should call sample_bipartite(), which then issues the deprecation warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maelle maelle

Labels
lifecycle Deprecating old APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Split sample_bipartite() into two functions for the G(n, m) and G(n, p) case igraph/rigraph
3 participants
@szhorvat @krlmlr @maelle