Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PDF docs build #735

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Disable PDF docs build #735

merged 1 commit into from
Aug 14, 2023

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Aug 11, 2023

As noted in #734, until we decide/invest enough time to enable the PDF builds for our docs (again), we should remove this version of the docs to keep the builds from failing.

How to review

I don't think we'll be able to build the PDF version from a PR build, we might be able to trigger a run manually on RTD for a branch build that builds epub and html, but no pdf. If not, we will only see this working after the merge, but the changes are small enough to understand they won't break anything.

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ ONly change docs config.
  • [ ] Add, expand, or update documentation. Only change docs config.
  • [ ] Update release notes. Only change docs config.

@glatterf42 glatterf42 added docs Documentation ci Continuous integration labels Aug 11, 2023
@glatterf42 glatterf42 requested a review from khaeru August 11, 2023 12:42
@glatterf42 glatterf42 self-assigned this Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #735 (d928f98) into main (e748b8c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #735   +/-   ##
=====================================
  Coverage   94.5%   94.5%           
=====================================
  Files         43      43           
  Lines       3463    3463           
=====================================
  Hits        3273    3273           
  Misses       190     190           

@khaeru khaeru changed the title Disable pdf docs build (see #743) Disable PDF docs build Aug 14, 2023
Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's update the description of #734 to indicate that it is a placeholder/record of some experimentation and attempts; that this current PR was the action taken for now; and that the attempts could be continued if that was judged high(er) priority.

@khaeru khaeru merged commit bf44691 into main Aug 14, 2023
19 checks passed
@glatterf42 glatterf42 deleted the fix/remove-pdf-docs branch August 14, 2023 08:47
@glatterf42 glatterf42 mentioned this pull request Aug 16, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants