Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand behaviour of create_canvas_from_iiif to allow setting the properties used in the ID #148

Open
digitaldogsbody opened this issue Dec 24, 2022 · 1 comment
Labels
defer Wait until a stronger usecase is found

Comments

@digitaldogsbody
Copy link
Member

Per @giacomomarchioro's suggestion in: #139 (review)

shall we provide the ability to set the format and the id of the body as args of the function, in case I want to show lower resolution or rotated images in the create_canvas_from_iiif?

I think this could be a useful thing to add, possibly as simple as adding the parameters of an Image API URL to the function with the defaults that are currently used in the explicit string version (although some thought needed for how this would handle the full->max change between v2 and v3).

@glenrobson glenrobson added the discuss For discussion in next catchup meeting label Jan 13, 2023
@glenrobson
Copy link
Contributor

Pass in region, size, rotation and format default to full/full and full/max.

Thank about what to do with file extension and corresponding mimetype in format.

Defer until we have a use case.

@glenrobson glenrobson removed the discuss For discussion in next catchup meeting label Jan 13, 2023
@digitaldogsbody digitaldogsbody added the defer Wait until a stronger usecase is found label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defer Wait until a stronger usecase is found
Projects
None yet
Development

No branches or pull requests

2 participants