Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AnnotationPageRef to the .to_reference() function #185

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add AnnotationPageRef to the .to_reference() function #185

wants to merge 3 commits into from

Conversation

digitaldogsbody
Copy link
Member

Allow AnnotationPageRef to be used now it is in the skeleton

@digitaldogsbody digitaldogsbody requested review from glenrobson and a team June 11, 2023 10:52
@digitaldogsbody digitaldogsbody mentioned this pull request Jun 11, 2023
Open
@digitaldogsbody
Copy link
Member Author

Tests will currently fail due to #186

@glenrobson
Copy link
Contributor

Tests don't seem to be running...

@glenrobson
Copy link
Contributor

It does fail on:

 File "/home/runner/work/iiif-prezi3/iiif-prezi3/tests/test_add_item.py", line 46, in test_add_by_reference
      self.assertIsInstance(self.ca.items[-1], AnnotationPageRef)
  AssertionError: AnnotationPage(id=Id(__root__=AnyUrl('http://example.org/iiif/6', scheme='http', host='example.org', tld='org', host_type='domain', path='/iiif/6')), type='AnnotationPage', label=None, context=None, rendering=None, service=None, thumbnail=None, items=[]) is not an instance of <class 'iiif_prezi3.skeleton.AnnotationPageRef'>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glenrobson glenrobson glenrobson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digitaldogsbody @glenrobson