-
-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix high severity issues reported by SonarCloud #2865
Comments
Most of the high severity issues fixed by @k1w1dev, but still 18 remain. See https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns |
I can start on these remaining issues. |
This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions. |
I'm new here, are all the issues fixed? |
I went to through this analysis https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns , mongoDB credentials were hardcoded, so I have added .env file and tested the changes, I have also added and updated dependencies in pom.xml. I have tested and it has passed. How to proceed now? |
Should I issue a PR for your review? |
@iluwatar I apologize for pinging you, but is this issue solved already, I have made some changes, just need your approval |
SonarCloud is used for static code analysis. It currently reports 48 high severity issues.
See https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns
It is possible to run the same analysis on local machine using SonarLint plugin. See instructions at https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions
Acceptance criteria
The text was updated successfully, but these errors were encountered: