Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action can fail incorrectly in certain cases #12

Open
mike-schenk opened this issue Jun 2, 2023 · 0 comments
Open

Action can fail incorrectly in certain cases #12

mike-schenk opened this issue Jun 2, 2023 · 0 comments

Comments

@mike-schenk
Copy link
Contributor

See that PR #11 was an incomplete solution to the problem that piping output from printf to grep (printf ... | grep ...) is subject to printf: write error: Broken pipe failure in certain cases.

It seems that if grep finds the matching tag close to a buffer boundary before printf is done writing its output, it will fail. This condition would be hard to predict or prevent when using a pipe.

grep should probably not be used with a pipe, but should read from a file on its own. See this StackOverflow question for more discussion.

Or, maybe it would be better to avoid grep and just implement search loop in bash with plain string matching, which could also fix #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant