You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many of the classes and interfaces in this project could be added to imglib2 core. Essentially, all packages that are not named unsafe plus most of net.imglib2.img.unsafe. The classes in net.imglib2.img.unsafe should be renamed from Unsafe<...> to LongAccess<...>.
This would leave only a small portion of the classes in imglib2-unsafe but these classes would all make use of sun.misc.Unsafe.
License headers and JavaDoc will need to be adjusted before moving any of the classes to imglib2 core.
I think that adding these methods and defaulting to their int counterpart is reasonable. I agree that it is the caller's responsibility to provide appropriate accesses. If necessary, callers can add their own validity checks for their access/images.
In addition, I think that what is currently called UnsafeImg and related classes should be added to imglib2 core as LongAccessImg (or similar name).
Updated:
As a consequence of unifying basictypeaccess and LongAccess, would that mean that NativeType will be changed to be accessible through long index? As with the access, the long access methods could default to their respective int counterparts.
Many of the classes and interfaces in this project could be added to
imglib2
core. Essentially, all packages that are not namedunsafe
plus most ofnet.imglib2.img.unsafe
. The classes innet.imglib2.img.unsafe
should be renamed fromUnsafe<...>
toLongAccess<...>
.This would leave only a small portion of the classes in
imglib2-unsafe
but these classes would all make use ofsun.misc.Unsafe
.License headers and
JavaDoc
will need to be adjusted before moving any of the classes toimglib2
core.Opinions? @axtimwalde @tpietzsch
The text was updated successfully, but these errors were encountered: