Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRWebGLLayer shouldn't expose context attribute #100

Open
takahirox opened this issue Oct 30, 2019 · 0 comments
Open

XRWebGLLayer shouldn't expose context attribute #100

takahirox opened this issue Oct 30, 2019 · 0 comments

Comments

@takahirox
Copy link
Contributor

XRWebGLLayer doesn't expose context attribute in the spec

https://www.w3.org/TR/webxr/#xrwebgllayer-interface

but it does in the polyfill

https://github.com/immersive-web/webxr-polyfill/blob/master/src/api/XRWebGLLayer.js#L74

It seems XRWebGLLayer.context is accessed from some places in the polyfill so renaming to _context like _session rather than hiding it would be good?
michaldybizbanski pushed a commit to michaldybizbanski/webxr-polyfill that referenced this issue May 1, 2020
@kvark
Merge pull request immersive-web#100 from kvark/doc-submission
b555093 
Add a small document about the submission model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@takahirox