Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRInputSourceArray #112

Open
lojjic opened this issue Nov 8, 2019 · 0 comments
Open

XRInputSourceArray #112

lojjic opened this issue Nov 8, 2019 · 0 comments

Comments

@lojjic
Copy link
Contributor

lojjic commented Nov 8, 2019

The spec defines session.inputSources as a XRInputSourceArray, a stripped-down arraylike interface. The polyfill currently exposes it as a regular JS array instead.

I ran into this when trying out Chrome beta's native implementation, where my polyfill-backed code was happily doing inputSources.map(...) which suddenly broke. The polyfill should implement the XRInputSourceArray interface and expose that instead.

I have a work in progress for this here - I welcome any suggestions or concerns with that approach before I work it up into a PR: https://github.com/lojjic/webxr-polyfill/tree/XRInputSourceArray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant