fix: library scanning cron job created on every instance instead of j…

…ust one
immich-app · Oct 25, 2024 · fa7dfc0 · fa7dfc0
1 parent c124cf9
commit fa7dfc0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/server/src/services/library.service.spec.ts b/server/src/services/library.service.spec.ts
@@ -117,6 +117,15 @@ describe(LibraryService.name, () => {
 
       expect(storageMock.watch).not.toHaveBeenCalled();
     });
+
+    it('should not initialize library scan cron job when lock is taken', async () => {
+      systemMock.get.mockResolvedValue(systemConfigStub.libraryWatchEnabled);
+      databaseMock.tryLock.mockResolvedValue(false);
+
+      await sut.onBootstrap();
+
+      expect(jobMock.addCronJob).not.toHaveBeenCalled();
+    });
   });
 
   describe('onConfigUpdateEvent', () => {

diff --git a/server/src/services/library.service.ts b/server/src/services/library.service.ts
@@ -51,12 +51,14 @@ export class LibraryService extends BaseService {
 
     this.watchLibraries = this.watchLock && watch.enabled;
 
-    this.jobRepository.addCronJob(
-      'libraryScan',
-      scan.cronExpression,
-      () => handlePromiseError(this.jobRepository.queue({ name: JobName.LIBRARY_QUEUE_SYNC_ALL }), this.logger),
-      scan.enabled,
-    );
+    if (this.watchLock) {
+      this.jobRepository.addCronJob(
+        'libraryScan',
+        scan.cronExpression,
+        () => handlePromiseError(this.jobRepository.queue({ name: JobName.LIBRARY_QUEUE_SYNC_ALL }), this.logger),
+        scan.enabled,
+      );
+    }
 
     if (this.watchLibraries) {
       await this.watchAll();