Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add developer notes about rootless docker setup #13250

Conversation

R-Rudolf
Copy link
Contributor

@R-Rudolf R-Rudolf commented Oct 7, 2024

Based on the earlier developer setup guide, after executing make dev, permission problems can occur in the web service, like the following:

immich_web               | failed to load config from /usr/src/app/vite.config.js
immich_web               | error when starting dev server:
immich_web               | Error: EACCES: permission denied, open '/usr/src/app/vite.config.js.timestamp-1727939078397-b40dceb29345c.mjs'

This is expected when using rootless docker, see moby/moby#45919.
In this PR the developer guide is extended with notes to mitigate the problem, and comments are added to the dev composer file as well.

@R-Rudolf R-Rudolf requested a review from bo0tzz as a code owner October 7, 2024 12:14
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 7, 2024
@R-Rudolf R-Rudolf force-pushed the docs-adding-rootless-docker-developer-notes branch from c0c9e9f to dc92b8d Compare October 7, 2024 12:15
@R-Rudolf R-Rudolf changed the title Add developer notes about rootless docker setup docs: Add developer notes about rootless docker setup Oct 7, 2024
@alextran1502
Copy link
Contributor

Can you help with formatting the docs with npm run format:fix?

@R-Rudolf R-Rudolf closed this Oct 9, 2024
@R-Rudolf
Copy link
Contributor Author

R-Rudolf commented Oct 9, 2024

Ohh, sorry I mistakenly closed the PR and now I do not have the permission to re-open it.

For a minute I thought close means merge. I am used to other repository platform.

Pleae help re-open, and as I understand only a final review is missing from the maintainer.

@danieldietzler danieldietzler reopened this Oct 9, 2024
@danieldietzler
Copy link
Member

Ohh, sorry I mistakenly closed the PR and now I do not have the permission to re-open it.

For a minute I thought close means merge. I am used to other repository platform.

Pleae help re-open, and as I understand only a final review is missing from the maintainer.

FYI you cannot just merge PRs lol

@zackpollard
Copy link
Contributor

zackpollard commented Nov 13, 2024

Hey @R-Rudolf, happy to get these changes merged in, but could you please remove the formatting changes mentioned above and make sure you're still happy with the changes? Also if you could fix the merge conflicts, that'd be great!

@zackpollard zackpollard changed the title docs: Add developer notes about rootless docker setup docs: add developer notes about rootless docker setup Nov 21, 2024
@zackpollard zackpollard merged commit 689c6aa into immich-app:main Nov 21, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:documentation documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants