Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Improvement to trackClonotypes #94

Open
EugeneRumynskiy opened this issue Aug 3, 2020 · 5 comments · May be fixed by #81
Open

ENH: Improvement to trackClonotypes #94

EugeneRumynskiy opened this issue Aug 3, 2020 · 5 comments · May be fixed by #81
Assignees
Labels
type:Enhancement New feature or request

Comments

@EugeneRumynskiy
Copy link
Contributor

EugeneRumynskiy commented Aug 3, 2020

🚀 Feature

Improvement to trackClonotypes(...)

Motivation

Pitch

Alternatives

Additional context

Currently, we have an initial tech spec for the function, that allows to start coding while I’m preparing the full Tech

Spec:

  • works on the standard data-metadata list (using the “Timepoint” field as a variable to order samples on the time line)
  • works on any number of samples
  • works on any columns (see the .col argument in trackClonotypes, feel free to copy the functionality from there - we will integrate your code inside trackClonotypes anyways)
  • doesn’t take into accounts replicas (we will add later if needed)

Internals:

  • subsets the data (using the Timepoint field to distinguish days for the subsequent clustering. Throw an error if no Timepoint field)
  • applies PCA
  • clusters trajectories using the best cluster determined automatically
    outputs the list with:
  • $pca - the PCA object
  • $data - the data frame with sequences, columns and the Cluster columns before the Samples with cluster indices, so people can easily use it later
  • $traj - trajectories
  • class immunr_trajectories
  • visualisations can be easily added later
@EugeneRumynskiy EugeneRumynskiy added the type:Enhancement New feature or request label Aug 3, 2020
@EugeneRumynskiy EugeneRumynskiy linked a pull request Aug 11, 2020 that will close this issue
@vadimnazarov
Copy link
Contributor

Additionally, for the documentation:

  • add links everywhere into "See Also"
  • update the tutorials inside functions' references

@vadimnazarov
Copy link
Contributor

ToDo for @vadimnazarov :

  • edge cases
  • progress bars

@vadimnazarov
Copy link
Contributor

  • trackClonotypes2 changes:
    • make sure there are two columns presented: "Timepoint" (for time points) and "Origin" (for patients)
    • Edge cases:
      • N: <0
      • metadata should contain the "Timepoints" column
    • Put in the doc that don't pass a large N if you don't have enough RAM

@vadimnazarov
Copy link
Contributor

progress bars – it's OK for now

@vadimnazarov
Copy link
Contributor

test it on the COVID-19 tutorial data before integrating it to the trackClonotypes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants