Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covid #81

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Covid #81

wants to merge 5 commits into from

Conversation

graceyraspberry
Copy link

I left placeholder text for where the images should go.

@EugeneRumynskiy EugeneRumynskiy changed the base branch from master to dev July 8, 2020 13:37
@EugeneRumynskiy
Copy link
Contributor

EugeneRumynskiy commented Jul 8, 2020 •
edited by vadimnazarov
Loading

@graceyraspberry
We added two new vignettes. What are the current blockers before we merge them into the dev branch?

  • Could we build the site?
  • Did we check for the typos?
  • We decided to turn off code-runs in this vignettes. Did it work?

@vadimnazarov
Copy link
Contributor

Is this a blocker? If not, what is the deadline for the review?

@graceyraspberry
Copy link
Author

Confirmed that external images work now, but I had to download and install png package in order for it to work, is the package included somewhere else or should I add the installation somewhere?

@EugeneRumynskiy EugeneRumynskiy linked an issue Aug 11, 2020 that may be closed by this pull request
ENH: Improvement to trackClonotypes #94
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MVolobueva MVolobueva MVolobueva approved these changes

Assignees

@graceyraspberry graceyraspberry

@EugeneRumynskiy EugeneRumynskiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Improvement to trackClonotypes
4 participants
@graceyraspberry @EugeneRumynskiy @vadimnazarov @MVolobueva