Skip to content
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.

No mention of having to fix tests for notifications in Lab 7 #193

Open
tmartensen opened this issue Mar 10, 2016 · 0 comments
Open

No mention of having to fix tests for notifications in Lab 7 #193

tmartensen opened this issue Mar 10, 2016 · 0 comments

Comments

@tmartensen
Copy link
Contributor

It seems that once someone is finished with Lab 7, there are a bunch of tests in test/unit/app/employees/controllers.spec.js that fail after all the lab instructions are finished. Recommend adding instructions for the lab to adding instructions for injecting the notifications service into the beforeEach where the api is being injected, as well as the two notifications stubs, and an example of how to tell if the notification stubs have been called or not:
Injector:

var notifications = $injector.get('notifications');

Stubs:

success: sinon.stub(notifications, 'success'),
error: sinon.stub(notifications, 'error')

Stubbing examples:

expect(spies.success).to.have.been.called;
expect(spies.error).to.not.have.been.called;
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@tmartensen and others