Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatExp redundant; use Stats #6

Open
in-op opened this issue Nov 11, 2017 · 0 comments
Open

StatExp redundant; use Stats #6

in-op opened this issue Nov 11, 2017 · 0 comments
Assignees
@in-op
Labels
duplicate

Comments

@in-op
Copy link
Owner

in-op commented Nov 11, 2017 •
edited
Loading

All uses of StatExp should be converted to Stats. Both data types are just a set of float fields for HP, Attack, etc. StatExp was mutable with the idea in mind that it would need to be updated after a battle, but was never actually used. If it ever does need to be implemented in the future, it can still be accomplished with the immutable Stats, just overload the + operator. tldr: StatExp: YAGNI
@in-op in-op self-assigned this Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@in-op in-op

Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@in-op