Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of check for base_excel #1208

Open
garbast opened this issue Jan 24, 2025 · 0 comments
Open

Replacement of check for base_excel #1208

garbast opened this issue Jan 24, 2025 · 0 comments

Comments

@garbast
Copy link

garbast commented Jan 24, 2025

I would like to suggest to replace the check in

$this->isPhpSpreadsheetInstalled = ExtensionManagementUtility::isLoaded('base_excel');

with an check for class_exists(\PhpOffice\PhpSpreadsheet\IOFactory)

By the changed check an installation which already uses phpoffice/phpspreadsheet for other tasks does not need to install base_excel to be able to export forms as xls. And TER users that rely on base_excel are fine too, because the factory is delivered by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants