Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test extraction of Reals -> Floats #1

Open
khieta opened this issue Apr 29, 2021 · 0 comments
Open

Test extraction of Reals -> Floats #1

khieta opened this issue Apr 29, 2021 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@khieta
Copy link
Member

khieta commented Apr 29, 2021

We extract Coq's axiomatized Reals (used for continuous gate parameters) to OCaml floats. This invites the possibility of floating point rounding error, which is not accounted for in our proofs. The best(?) way to get around this would be to actually reason about float parameters in Coq -- but I'd rather avoid this if possible.

If we are going to leave the extraction as-is, then we should at least have solid evidence that it isn't doing significant harm. Here are a couple random ideas for testing:

  • Optimize (small) random programs with optimize_1q_gates, compute the matrices corresponding to the input and output programs, and check the two for equivalence.
  • Compare the results of VOQC's optimize_1q_gates and Qiskit's Optimize1qGates on random input programs.
@khieta khieta added the help wanted Extra attention is needed label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant