Small logging fix (#710)

* Fixing a small bug with accessing undefined * Fix error with a race condition in logging
inaturalist · Sep 3, 2024 · 84b3584 · 84b3584
1 parent bd43281
commit 84b3584
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/components/Navigation/hooks/useAppLog.ts b/components/Navigation/hooks/useAppLog.ts
@@ -6,17 +6,19 @@ import { LogLevels, logToApi } from "../../../utility/apiCalls";
 import taxonIds from "../../../utility/dictionaries/taxonDict";
 import realmConfig from "../../../models/index";
 
-const runOncePerMonth = async ( callback: () => void ) => {
+const executeInNewMonth = async ( callback: () => void, keySubstring: string ) => {
+  const storageKeyBase = "lastRunMonth";
+  const storageKey = storageKeyBase + keySubstring;
   try {
-    const lastRun = await AsyncStorage.getItem( "lastRunMonth" );
+    const lastRun = await AsyncStorage.getItem( storageKey );
     const currentMonth = new Date().getMonth();
 
     if ( lastRun === null || parseInt( lastRun, 10 ) !== currentMonth ) {
       // Run the function as the month has changed
       callback();
 
       // Update the last run month
-      await AsyncStorage.setItem( "lastRunMonth", currentMonth.toString() );
+      await AsyncStorage.setItem( storageKey, currentMonth.toString() );
     }
   } catch ( error ) {
     console.error( "Error checking or updating last run month:", error );
@@ -45,8 +47,8 @@ function useAppLog() {
 
       const levelsEarned = badges.filtered( "iconicTaxonName == null AND earned == true" ).sorted( "count", true );
       const level = {
-        earnedDate: levelsEarned[0].earnedDate,
-        index: levelsEarned[0].index
+        earnedDate: levelsEarned[0]?.earnedDate,
+        index: levelsEarned[0]?.index
       };
 
       const achievementsLogState = {
@@ -56,12 +58,12 @@ function useAppLog() {
       await logToApi( {
         level: LogLevels.INFO,
         message: JSON.stringify( achievementsLogState ),
-        context: "RootStack achievementsState",
+        context: "RootStack achievementsState v1",
         errorType: "0"
       } );
     };
 
-    runOncePerMonth( logBadgesAppState );
+    executeInNewMonth( logBadgesAppState, "1" );
   }, [] );
 
   useEffect( ( ) => {
@@ -81,12 +83,12 @@ function useAppLog() {
       await logToApi( {
         level: LogLevels.INFO,
         message: JSON.stringify( challengesLogState ),
-        context: "RootStack challengesState",
+        context: "RootStack challengesState v1",
         errorType: "0"
       } );
     };
 
-    runOncePerMonth( logChallengesAppState );
+    executeInNewMonth( logChallengesAppState, "2" );
   }, [] );
 
   useEffect( ( ) => {
@@ -104,12 +106,12 @@ function useAppLog() {
       await logToApi( {
         level: LogLevels.INFO,
         message: JSON.stringify( observationsLogState ),
-        context: "RootStack observationsState",
+        context: "RootStack observationsState v1",
         errorType: "0"
       } );
     };
 
-    runOncePerMonth( logChallengesAppState );
+    executeInNewMonth( logChallengesAppState, "3" );
   }, [] );
 }