Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include notifications about observations by others in Notifications #2451

Closed
8 tasks done
kueda opened this issue Nov 18, 2024 · 1 comment · Fixed by #2491
Closed
8 tasks done

Include notifications about observations by others in Notifications #2451

kueda opened this issue Nov 18, 2024 · 1 comment · Fixed by #2491
Assignees
@kueda
Labels
enhancement New feature or request iNat Next
Milestone
Hard Launch (iOS)

Comments

@kueda
Copy link
Member

kueda commented Nov 18, 2024 •
edited
Loading

This should be fairly light

Design needs:

  • Two tab layout
  • Where do we show new content indicators

Implementation

  • Two tabs, one shows what's currently in Notifications (notifcaitons about your own obs), and the other shows notifications about other people's obs
  • Each tab has an indicator showing whether there's unviewed content there
  • Add new translation keys for notifications-user1-added-comment-to-observation-by-user2 and notifications-user1-added-identification-to-observation-by-user2
  • Make sure the VOWORCON() Fluent function works, b/c Romance language translators will really need it for those two new keys
  • Notifications icon in bottom tabs should show a new content indicator if there's new stuff on either tab
  • Test the tabs with some longer text. The should ellipsize if there's overflow
@kueda kueda added the enhancement New feature or request label Nov 18, 2024
@kueda kueda moved this to Todo in iNat Mobile Nov 18, 2024
@abhasinat
Copy link

Here are the new designs.

Key changes from what we have now:

  • Tabs added to the header that is sticky to the top of the screen
  • Each tab has a read and unread state (with and without a content indicator)
  • The My observations tab shows all activity related to my observations
  • The Others' observations tab shows all activity related to others' notifications

@abhasinat abhasinat removed their assignment Nov 19, 2024
@abhasinat abhasinat added this to the Hard Launch (iOS) milestone Nov 19, 2024
@kvangork kvangork added the Improvement label Nov 19, 2024 — with Linear
@kvangork kvangork removed the enhancement New feature or request label Nov 19, 2024
@kvangork kvangork added the enhancement New feature or request label Nov 19, 2024 — with Linear
@kvangork kvangork added the iNat Next label Nov 19, 2024 — with Linear
@kueda kueda self-assigned this Nov 19, 2024
@kueda kueda moved this from Todo to In Progress in iNat Mobile Nov 27, 2024
@kueda kueda mentioned this issue Nov 27, 2024
Merged
@kueda kueda closed this as completed in 7f9a272 Nov 28, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in iNat Mobile Nov 28, 2024
jtklein added a commit that referenced this issue Dec 5, 2024
@jtklein @kueda
@angielt @crowdin-bot
Get altitude for user location; Add Geo model (#2492)
df4ff64 
* Also collect altitude from geolocation calls

* Update geomodel plugin

* Prop user location down into ai camera

* Add geo model file to be linked into xcode project

* Update env.example

* Update env.example

* Add geo model to cv model info file

* Update Developer.js

* Use user location for geo model while frame processing

useGeoModel boolean signals the frame processing plugin to use the geo model as well. It is turned on when we have a location.

* Update README.md

* Geo model is optional

* Adding a dummy neural network called geomodel.placeholder

This model doesn't do anything just returns the input. This is a overhead we could justify in my view as not to spend some more time figuring out how to make a model optional in an Xcode project.

* Geo model files are optional

* Update README.md

* Fix wrong model usage

* Update README.md

* This comment is no longer true

* feat: use full-text index on new _searchableName field (#2487)

Supports searches across non-contiguous tokens, e.g. finding "Mount Diablo
fairy lantern" with a query like "diablo lantern"

Related to #2348

* feat: add pull to refresh on notifications (#2489)

Closes #2349

* feat: show notifications from others (#2491)

* split notifications into tabs
* lots of TypeScript conversion
* feat: resize Heading5 and add Heading6 (closes #2480)
* fix: mark remote observations as viewed from ObsDetails
* feat: show indicator in Notifications tabs if unviewed notifications

Closes #2451

* feat: add option to save all observations from batch obs edit (#2493)

* fix: bring KebabMenu in line with designs

Closes #2268

* Update testing instructions

* v0.55.2

* v0.55.2+129

* fix: show observation from external link when Explore filters open (#2453)

* Open observation in app when link is pressed even if modals are open

* Remove comments

* Add comment and reset obsid

* fix: show onboarding content when signed in user has 0 observations (#2510)

Closes #2508

* fix: load new Explore results when filters change (#2507)

URL params got removed from the query key as a part of pull-to-refresh, but
that's how changes to filters were triggering a new request. This restores
that behavior, adds a test to ensure changes to filters call the API again,
and fixes the prior test of pull to refresh which was not testing the
equivalent behavior when pulling to refresh (API on first load, so the mock
needed to be cleared).

* fix: restore observation fetch when focusing on myobs (#2511)

* fix: center number in photo count (#2512)

Closes #2506

* refactor: minor edits for clarity

* fix: specify CV model version in e2e test

Hoping this deflakes the e2e a bit. Not sure why the AICamera test ever worked
without this.

* v0.55.3

* v0.55.3+130

* New Crowdin translations by GitHub Action (#2481)

Co-authored-by: Crowdin Bot <[email protected]>

* fix: get quality grade descs closer to designs; add Joanne to staff (#2517)

* fix: prevent BottomSheet title from overflowing over close button

* Update to Geomodel name

* Another name change

* Rename var and const names

* Rename const file references

* Also collect altitude from geolocation calls

* Update geomodel plugin

* Prop user location down into ai camera

* Add geo model file to be linked into xcode project

* Update env.example

* Update env.example

* Add geo model to cv model info file

* Update Developer.js

* Use user location for geo model while frame processing

useGeoModel boolean signals the frame processing plugin to use the geo model as well. It is turned on when we have a location.

* Update README.md

* Geo model is optional

* Adding a dummy neural network called geomodel.placeholder

This model doesn't do anything just returns the input. This is a overhead we could justify in my view as not to spend some more time figuring out how to make a model optional in an Xcode project.

* Geo model files are optional

* Update README.md

* Fix wrong model usage

* Update README.md

* This comment is no longer true

* refactor: minor edits for clarity

* Update to Geomodel name

* Another name change

* Rename var and const names

* Rename const file references

---------

Co-authored-by: Ken-ichi <[email protected]>
Co-authored-by: Angie <[email protected]>
Co-authored-by: Crowdin Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kueda kueda

Labels
enhancement New feature or request iNat Next
Projects
iNat Mobile
Status: Done
Milestone
Hard Launch (iOS)
Development

Successfully merging a pull request may close this issue.

feat: show notifications from others inaturalist/iNaturalistReactNative
3 participants
@kueda @kvangork @abhasinat