Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RpiGPIO driver crashes when loading a saved configuration #881

Open
FireNWater opened this issue Jan 11, 2024 · 4 comments
Open

RpiGPIO driver crashes when loading a saved configuration #881

FireNWater opened this issue Jan 11, 2024 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@FireNWater
Copy link

After Saving a Configuration under the Options tab, any attempt to Load results in driver crash. If there are no Configuration files in the /home/stellarmate/.indi/ folder, the driver does not crash.

To Reproduce
Exact steps to reproduce the behavior.

  1. Run driver
  2. Save a Configuration tab
  3. Load a Configuration tab
  4. Crash

Expected behavior

  1. I expected the driver to load the configuration I had set up just before clicking "Save"

Screenshots
I have included copies of a fresh configuration file(s) that the driver produces on the first run after deleting the previous configuration files from the /.indi/ folder.

Desktop (please complete the following information):
-StellarMate OS ver 1.8.0 / Stable / SM-110
-Rpi 4 / 8GB

Log Files
Make sure to enable logging and include log files Rpi_GPIO_INDI_Logs_Crash.zip

@FireNWater FireNWater added the bug Something isn't working label Jan 11, 2024
@knro
Copy link
Collaborator

knro commented Jan 12, 2024

Thank you for the report. I also think the driver is missing configuration for Raspberry PI 5 + CM4. I hope @ken-self knows what's going on, I'll try to also debug from my side.

@ken-self
Copy link
Contributor

Looks like pigpio does not work with RPi 5 due to archiitectural incompatibility.
joan2937/pigpio#589

@knro
Copy link
Collaborator

knro commented Jan 14, 2024

It appears that this driver should probably migrate to libgpiod. Yesterday, I migrated a driver for my rolloff roof to this and it was pretty easy. For example:

auto chip = gpiod::chip("gpiochip0");
auto open_line = chip.get_line(FULL_OPEN_PIN);
open_line.request({"ikarus_roof", gpiod::line_request::DIRECTION_INPUT, 0});
full_open_state   = open_line.get_value();

I've added FindGPIOD.cmake so that 3rd party projects can link against the C++ GPIO bindings.

@knro knro added the help wanted Extra attention is needed label Jan 23, 2024
@knro
Copy link
Collaborator

knro commented Jan 23, 2024

Anyone willing to volunteer migrating this to the new libgpiod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants