Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better types 2024 #290

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Better types 2024 #290

merged 9 commits into from
Nov 29, 2024

Conversation

inducer
Copy link
Owner

@inducer inducer commented Nov 27, 2024

No description provided.

@inducer inducer marked this pull request as ready for review November 28, 2024 00:23
@inducer inducer requested a review from alexfikl November 28, 2024 00:23
@inducer inducer mentioned this pull request Nov 28, 2024
Merged
1 task
alexfikl
alexfikl reviewed Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@alexfikl alexfikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nitpicks, but overall adding some arithmetic to the types sounds good to me.

Maybe it's worth even making the default *T versions be arithmetic? I can't think of a case where we'd want to be more general..

arraycontext/container/__init__.py Show resolved Hide resolved
arraycontext/container/dataclass.py Outdated Show resolved Hide resolved
arraycontext/container/dataclass.py Outdated Show resolved Hide resolved
arraycontext/context.py Outdated Show resolved Hide resolved
arraycontext/impl/pytato/utils.py Outdated Show resolved Hide resolved
test/test_arraycontext.py Show resolved Hide resolved
test/test_utils.py Outdated Show resolved Hide resolved
test/test_utils.py Show resolved Hide resolved
@inducer inducer enabled auto-merge (rebase) November 29, 2024 21:32
@inducer
Copy link
Owner Author

inducer commented Nov 29, 2024

Thanks for reviewing!

@inducer inducer merged commit 0e12edf into main Nov 29, 2024
12 checks passed
@inducer inducer deleted the better-types-2024 branch November 29, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfikl alexfikl alexfikl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inducer @alexfikl