-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation on windows #14
Comments
I would love to enable that somehow, but I don't have a Windows development environment available. As such, I can at best help you troubleshoot. Maybe post some errors that you're seeing, and then we can muddle through together? |
sure, I want participate too ! |
not sure if you are looking for a installation package for windows because On Sat, Jul 11, 2015 at 2:52 AM, Liu Benyuan [email protected]
|
Hi ! It works ! However, will you compile a newer version of meshpy that supports both i.e., in if volume_constraints:
opts += "a"
if max_volume:
opts += "a%.20f" % max_volume |
You'd have to ask Christoph Gohlke that (who maintains those binaries). |
I don't know much about Windows builds, but I had started a meshpy conda-forge package at a point: conda-forge/staged-recipes#1480 I've given you access to the source branch in case you would like to use that as the basis for your work. |
I didn't know there is already staged-recipe setup. I have setup one for linux some time ago: |
Thanks for your work on this. Could you send a pull request? |
Once it is working on windows I will try to create a pull request. |
I tried to find the boost-directories with cmake. But the tests are not working because of some linking problems.
The diff can be found here: |
after wasting a lot of time, I have made meshpy build on linux with using cmake.
maybe @peterlama can help with this. I think we had similar issues with netgen some time ago... |
ok I think I have a working windows build. @inducer maybe you can have a look if it is possible to merge my changes: After this is done, we can work on the conda-forge recipe. I have uploaded a win-package to https://anaconda.org/OpenGlider/meshpy/files which can be used until the conda-forge package is ready. |
Thank you for working on this. Next time, please
Seriously, this took me about 45 minutes to clean up to be even half robust and usable. I appreciate your work, but you've got to be more careful. See 58db625 for my changes. |
thanks for merging this into this branch. I know some things were not perfect yet, and this is because I did not understand your build fully... It was only an idea to find boost-python with cmake. At the beginning I wasn't sure if this will work, so I simple tried it step by step. And my branch was the result of this. So not very clean. I just wanted to make sure my way of handling the boost dependencies is the way to proceed. For a PR I would have cleaned the branch. I do not understand your 3rd point . Is this about the cmake? |
Hmm. Unfortunately (as I learned on my own machine), this cuts both ways. Python 3 will happily link against the Py2 Boost.Python library, and once imported, the resulting module will crash the interpreter without a meaningful message. My vote would be to restrict to the |
You can also check the boost version and support python3 only if it is higher than 1.64. Boost-python is anyway a quite difficult dependency. Have you ever thought about updating to pybind11? It's header only, and therefore not problematic regarding version mismatch. |
I would like that, but I don't have the time to do it at the moment. |
It looks like to install meshpy you need a UNIX machine. Is there the possibility of getting a windows supported meshpy release? I am not sure how many things had to be changed, but I think that just taking out the timing (sys/time.h does not exist on windows) may be enough.
I can help with that but I am quite new to python and don't know much about UNIX-WINDOWS differences at this level. I offer my help anyways.
The text was updated successfully, but these errors were encountered: