-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vite instructions to README.md #10
base: main
Are you sure you want to change the base?
Conversation
061267e
to
856e27a
Compare
Thanks @davidschrooten , this is great! I'd like to add some sort of React/Vue documentation as well if we're adding Svelte.. maybe something like a small sample folder of markdown examples would help? Only thing I'm unsure of is if we want to document whitenoise here, in my mind that's a deployment issue, not something associated with Inertia. What do you think? I'm a little slow to cut releases right now because it's American Thanksgiving week so I appreciate your patience! |
|
||
Install the following python packages via pip | ||
```bash | ||
pip install django-vite whitenoise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need whitenoise, but your example uses the Django adapter for InertiaJS.
Maybe we can swap those?
pip install django-vite whitenoise | |
pip install django-vite inertia-django |
MIDDLEWARE = [ | ||
# ... | ||
"django.middleware.security.SecurityMiddleware", | ||
"whitenoise.middleware.WhiteNoiseMiddleware", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps better to keep the whitenoise config as an example rather than within the vite and inertia setup?
# If use HMR or not. We follow Django's DEBUG mode | ||
DJANGO_VITE_DEV_MODE = DEBUG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate setting
# If use HMR or not. We follow Django's DEBUG mode | |
DJANGO_VITE_DEV_MODE = DEBUG |
Include instructions how to setup vite with inertia, for backend and frontend part.
#3