"Power button ends call" setting is broken

[ProjectOpenCannibal]

I've been doing some toying around with this issue, and may have found a fix.

A workaround (which is half-assed, and DEFINITELY breaks the setting), is to switch the locked-in default to NOT hang up the call. Like so:

1. In packages/apps/Phone/lsrc/com/android/phone/PhoneInterfaceManager.java
2. Find "case CMD_END_CALL"
3. Find the line that says "hungUp = PhoneUtils.hangupRingingAndActive(mPhone);"
4. Change "PhoneUtils.hangupRingingAndActive(mPhone);" to "false;"
5. The whole line then reads: "hungUp = false;"
6. The power button will no longer hang up the call, but the actual setting is still broken.

As I said though, I may have found a fix that allows the setting to actually work as expected. Once it compiles and I test it, I'll update this issue.

[ProjectOpenCannibal]

No fix yet, still working on it.

[inferiorhumanorgans]

If you find a fix I'd suggest submitting it to gerrit.

[mik9]

It's not a CM bug, it's a keylayout problem: mik9@0061b0c#diff-10

[inferiorhumanorgans]

Thanks!

[inferiorhumanorgans]

Unfortunately this doesn't fix the problem for me. I needed to also (perhaps only) edit qwerty.kl which is a CM file. This /may/ be a kernel issue as I've taken all the key events out of ats_input, but I doubt it since other home/menu keymappings seem to work fine from the thunder keymap.

[mik9]

Maybe you need make same patch for 7k_handset.kl (I forgot about it):
mik9@0061b0c#diff-4

[inferiorhumanorgans]

Nope. I don't have that file installed at all (which might? create BT problems, but that's for another day).

$ adb ls /system/usr/keylayout 000041ed 00000800 4e345863 . 000041ed 00000800 4e31d95f .. 000081b6 00000655 4e3452c4 thunder_keypad.kl 000081b6 0000072a 4e34584d qwerty.kl 000081a4 000000f5 4892fac0 AVRCP.kl

[BobZhome]

The following 7k_handset.kl fixes this issue and does not break BT.
BobZhome@eeb8933

[inferiorhumanorgans]

I don't see how that changes anything substantive regarding the power
button. The problem, AFAIK, lies in one of the emulator keyboard files
that CM pulls in regardless. Rather than fork a repository just for
that, I've left it alone for now.

[JerryScript-duplicate]

@bob: That fixes the headset button (mostly), I'm looking for the author to cite, will submit pull request asap.

[inferiorhumanorgans]

That commit only changes the whitespace on line for the power key. The problem that I had is that there's something else mapping 107 to "ENDCALL" and I didn't want to fork another repository to change one line.

[BobZhome]

The problem is the 7k_handset.kl file is not being copied to the build...you need to pull JerryScript@4cef647

[JerryScript-duplicate]

Sorry, all my commits somehow where added to the pull request. I hate this git stuff.