Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify parts of the code where implementing standard traits would make sense #8

Open
17 of 70 tasks
steveatinfincia opened this issue Aug 4, 2017 · 2 comments
Open
17 of 70 tasks

Comments

@steveatinfincia
Copy link
Member

steveatinfincia commented Aug 4, 2017

Things like AsRef, Into, From, etc.

AsRef<str> and AsRef<[u8]> are implemented in a few spots now, in ways that are hopefully unsurprising and where the semantic meaning is obvious. There may be others that would be useful without making the crate unnecessarily complicated to use.

Semi-related to #4

  • AsRef<str>
  • AsRef<[u8]>
  • Debug
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • Copy
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • Clone
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • Default
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • From<&str>
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • From<&[u8]>
    • Mnemonic
      • Might make sense to create a Mnemonic from externally created/stored entropy
    • MnemonicType
    • Seed
    • Language
  • Eq
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • PartialEq
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • Ord
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • PartialOrd
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • Hash
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
  • Display
    • Mnemonic
    • MnemonicType
    • Seed
    • Language
@lsaether
Copy link

Hey thanks for building this! I was really surprised (but pleasantly surprised!) when I got a hit for my search of "bip39" on crates.io. I'm currently working on building an Ethereum light wallet / signing client and this will help greatly.

If I have time I'll definitely contribute back by implementing some of these standard traits.

@steveatinfincia
Copy link
Member Author

Hi @lsaether, I'm glad you find the crate useful!

If you run in to any problems using it, or if there is anything you would like to see added or changed, please let me know and I will gladly help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants